Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSM] PEPPER-947 changes from RC #2618

Merged
merged 7 commits into from
Aug 4, 2023
Merged

[DSM] PEPPER-947 changes from RC #2618

merged 7 commits into from
Aug 4, 2023

Conversation

pegahtah
Copy link
Contributor

@pegahtah pegahtah commented Jul 5, 2023

Fixing RGP's RNA kit label not getting saved

denniscunningham
denniscunningham reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@denniscunningham denniscunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is that we are now bringing processRGPFinalScan on-line, but may not have a good way of testing/validating its correctness?
Offhand I don't see any JUnit tests for this?

@pegahtah
Copy link
Contributor Author

pegahtah commented Aug 1, 2023

My main concern is that we are now bringing processRGPFinalScan on-line, but may not have a good way of testing/validating its correctness? Offhand I don't see any JUnit tests for this?

Hi Dennis no there are not, we only tested it manually
If you look at the git history this change got dropped around March because two branches that were changing the same part of the code kinda over rode each other.

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pegahtah pegahtah merged commit a36e412 into develop Aug 4, 2023
5 checks passed
@pegahtah pegahtah deleted the PEPPER-947 branch August 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniscunningham denniscunningham denniscunningham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pegahtah @denniscunningham